Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert exported modules to typescript #599

Merged
merged 4 commits into from
Mar 19, 2021
Merged

fix: convert exported modules to typescript #599

merged 4 commits into from
Mar 19, 2021

Conversation

ph-fritsche
Copy link
Member

What:

Converted all exported modules to Typescript.
Fixed some bugs / false assumptions along the way.
Added more TODOs to verify previous implementations.

Why:

Closes #598
Closes #594 (hopefully this time for good)

Checklist:

  • N/A Documentation
  • Tests
  • N/A Typings
  • Ready to be merged

@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #599 (a758238) into master (a552f18) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #599   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        47           
  Lines          862       871    +9     
  Branches       327       329    +2     
=========================================
+ Hits           862       871    +9     
Impacted Files Coverage Δ
src/clear.ts 100.00% <100.00%> (ø)
src/click.ts 100.00% <100.00%> (ø)
src/paste.ts 100.00% <100.00%> (ø)
src/select-options.ts 100.00% <100.00%> (ø)
src/tab.ts 100.00% <100.00%> (ø)
src/upload.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a552f18...a758238. Read the comment docs.

@ph-fritsche ph-fritsche merged commit be0b1b6 into master Mar 19, 2021
@ph-fritsche ph-fritsche deleted the fix-594 branch March 19, 2021 16:28
@github-actions
Copy link

🎉 This PR is included in version 13.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

text,
init,
{initialSelectionStart, initialSelectionEnd} = {},
element: HTMLInputElement | HTMLTextAreaElement,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This type definition makes it impossible to use elements returned by RTS queries, without type casting.

see: #648

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a PR to fix this: #649

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants